From: Junio C Hamano Date: Thu, 09 Jul 2026 03:36:17 GMT Subject: Re: [PATCH v3 08/11] odb/transaction: add transaction env interface Message-ID: In-Reply-To: <20260708235925.3992097-9-jltobler@gmail.com> Justin Tobler writes: > +static int odb_transaction_files_env(struct odb_transaction *base, > + struct strvec *env) > +{ > + struct odb_transaction_files *transaction = > + container_of(base, struct odb_transaction_files, base); > + > + odb_transaction_files_prepare(&transaction->base); Can this fail? The caller of us would not notice that something went wrong, and ... > + strvec_pushv(env, tmp_objdir_env(transaction->objdir)); ... happily ends up using transaction->objdir that may not be appropriate for it to use if it fails, no? > + return 0; > +}