From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 05 Mar 2014 22:55:07 GMT
Subject: Re: [PATCH v6 04/11] trailer: process command line trailer arguments
Message-ID: <xmqqa9d41cj8.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140304194810.14249.51930.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

> diff --git a/trailer.c b/trailer.c
> index 5b8e28b..5d69c00 100644
> --- a/trailer.c
> +++ b/trailer.c
> @@ -378,3 +378,96 @@ static int git_trailer_config(const char *conf_key, const char *value, void *cb)
> ...
> +static struct trailer_item *new_trailer_item(struct trailer_item *conf_item,
> +					     char* tok, char* val)

Asterisk sticks to the variable, not the type.

> +static struct trailer_item *create_trailer_item(const char *string)
> +{
> ...
> +	return new_trailer_item(NULL, strbuf_detach(&tok, NULL), strbuf_detach(&val, NULL));;

Overlong line.  Perhaps that helped you to miss the double-semicolon
at the end.