From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 30 May 2014 18:45:36 GMT
Subject: Re: [PATCH] Improve function dir.c:trim_trailing_spaces()
Message-ID: <xmqqa99z9kbz.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140530020444.GH28683@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Thu, May 29, 2014 at 02:34:33PM -0700, Pasha Bolokhov wrote:
>
>> > However, I doubt it makes that much of a difference in practice, so
>> > unless it's measurable, I would certainly go with the version that is
>> > more readable (and correct, of course).
>> 
>>     Sorry, just to recap, you would go with the existing version
>> (which needs correction), or with the one that is being suggested? (I
>> agree I can format the style a tiny bit better in the latter one)
>
> I actually think the original left-to-right is a little easier to
> follow, but I do not feel strongly. I mainly meant "argue based on
> readability and correctness, do not argue based on speed".

Sensible.

> I'd be OK with either, though I have a slight preference for the first,
> just because I find the "bslash ^= 1" bit of yours, while clever, a bit
> hard to follow.

FWIW, I think I agree.