From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 28 Jan 2016 23:51:44 GMT
Subject: Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override
Message-ID: <xmqqa8npl0tr.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1453638170-52041-1-git-send-email-larsxschneider@gmail.com>

larsxschneider@gmail.com writes:

> -	if (ca.drv) {
> +	if (ca.drv && ca.drv->smudge && strlen(ca.drv->smudge)) {

You are not interested in its length, but if it is an empty string
or not, so I'd tweak this like so:

> +	if (ca.drv && ca.drv->smudge && *ca.drv->smudge) {