From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 27 Jun 2016 15:00:06 GMT
Subject: Re: [PATCH v2 00/12] nd/icase updates
Message-ID: <xmqqa8i6d6dl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqeg7id6ns.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

>  	if (p->fixed) {
>  		p->kws = kwsalloc(icase ? tolower_trans_tbl : NULL);
>  		kwsincr(p->kws, p->pattern, p->patternlen);
>  		kwsprep(p->kws);
>  		return;
>  	} else if (opt->fixed) {
> +		/*
> +		 * We only come here when the pattern has the regexp
> +		 * special characters in it, which need to be matched
> +		 * literally, while ignoring case.
> +		 */

This comment is wrong.

		/*
		 * We come here only when the pattern has non-ascii
		 * characters we cannot case-fold, and we were asked
		 * to ignore-case.
		 */

>  		compile_fixed_regexp(p, opt);
>  		return;
>  	}