From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Aug 2016 16:16:03 GMT
Subject: Re: [PATCH v4 03/12] pkt-line: add packet_flush_gentle()
Message-ID: <xmqqa8gs5x30.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160803213920.jg3eshy57bsldqjh@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>   2. It calls check_pipe(), which will turn EPIPE into death-by-SIGPIPE
>      (in case you had for some reason ignored SIGPIPE).
> ...
>
> Thinking about (2), I'd go so far as to say that the trace actually
> should just be using:
>
>   if (write_in_full(...) < 0)
> 	warning("unable to write trace to ...: %s", strerror(errno));
>
> and we should get rid of write_or_whine_pipe entirely.

I like the simplicity the above suggestion gives us.