From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 Nov 2016 23:16:48 GMT
Subject: Re: [PATCH v5 01/16] Git.pm: add subroutines for commenting lines
Message-ID: <xmqqa8d88crj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <b01d0d90-f87c-f708-5d2a-79f6268b4f44@gmail.com>

Jakub Narębski <jnareb@gmail.com> writes:

>> I prefer to have like this instead
>> 
>> sub prefix_lines {
>>         my $prefix = shift;
>>         my $string = join("\n", @_);
>>         $string =~ s/^/$prefix/mg;
>>         return $string;
>> }
>> 
>> So both subroutines can take several strings as arguments.
>
> I like the interface, but the implementation looks a bit inefficient.
> Why not simply:
> ...
> If those strings can contain embedded newlines (so that they can be
> called as in Junio example), then your solution is a must-be
>
>   sub prefix_lines {
>           my $prefix = shift;
>           my $string = join("\n", @_);
>           $string =~ s/^/$prefix/mg;
>           return $string;
>   }
>
> Well, nevermind then

OK, so in short, is that a "Reviewed-by:" from you ;-)?

I agree with the conclusion.  Thanks for a review.