From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 02 Oct 2017 09:52:09 GMT
Subject: Re: [PATCH v6 7/7] ref-filter.c: parse trailers arguments with %(contents) atom
Message-ID: <xmqqa819op12.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171002065100.cjawz6pvxjj2w5nr@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>>  		atom->u.contents.option = C_SUB;
>> -	else if (!strcmp(arg, "trailers"))
>> -		atom->u.contents.option = C_TRAILERS;
>> -	else if (skip_prefix(arg, "lines=", &arg)) {
>> +	else if (skip_prefix(arg, "trailers", &arg)) {
>> +		skip_prefix(arg, ":", &arg);
>> +		trailers_atom_parser(format, atom, *arg ? NULL : arg);
>
> I think your logic is flipped. You want "*arg ? arg : NULL";

Ahh, I was blind.  Will fix locally and push the results out.

Thanks.