From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 31 Mar 2021 00:04:56 GMT
Subject: Re: [PATCH v2 19/22] xdiff-interface: allow early return from xdiff_emit_{line,hunk}_fn
Message-ID: <xmqqa6qk9oif.fsf@gitster.g>
In-Reply-To: <20210216115801.4773-20-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Change the function prototype of xdiff_emit_{line,hunk}_fn to return
> an int instead of void. This will allow for returning early from hunk
> & diff consumers that want some of the data, but not all of it.
>
> No behavior is being changed here, just replacing the equivalent of
> "return" with "return 0", nothing acts on the changed return values
> yet.

So, is this "allowing" early return yet?  I am looking at the patch
title and then reading the above paragraph and wondering.

Or is this step "preparation for allowing" and the real fun is left
for later steps?