From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 09 Apr 2021 22:32:20 GMT
Subject: Re: [PATCH 2/2] object.c: initialize automatic variable in lookup_object()
Message-ID: <xmqqa6q7m6mj.fsf@gitster.g>
In-Reply-To: <YHCUmM7CqJ83ZXrL@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

>>  struct object *lookup_object(struct repository *r, const struct object_id *oid)
>>  {
>>  	unsigned int i, first;
>> -	struct object *obj;
>> +	struct object *obj = NULL;
>>  
>>  	if (!r->parsed_objects->obj_hash)
>> -		return NULL;
>> +		return obj;
>
> I actually prefer the original style (where any "can we bail early"
> checks just explicitly return NULL, rather than making you check to see
> that obj is NULL).

Perhaps I should return "me too" here.