From: Junio C Hamano Date: Thu, 30 Dec 2021 22:36:42 GMT Subject: Re: [PATCH v3 03/11] i18n: turn "options are incompatible" into "cannot be used together" Message-ID: In-Reply-To: <48262743.WQR3eRXon5@cayenne> Jean-Noël AVILA writes: >> > if (!revs->reflog_info && revs->grep_filter.use_reflog_filter) >> > - die("cannot use --grep-reflog without --walk-reflogs"); >> > + die(_("%s requires %s"), "--grep-reflog", "--walk-reflogs"); >> >> This last transformation does not fit the topic of this patch. It should >> go into patch 6/11, I think. >> > > True! Will reroll after checking again. Also, it lacks single-quote-pair around %s's; intended?