From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Jan 2022 17:08:17 GMT
Subject: Re: [PATCH v3 2/2] wrapper: use a CSPRNG to generate random file names
Message-ID: <xmqqa6fl6ozi.fsf@gitster.g>
In-Reply-To: <f31dd12e-6d27-a070-77e4-ad53fb319735@web.de>

René Scharfe <l.s.r@web.de> writes:

> ...  But
> a replacement for git_mkstemp_mode() with two umask(2) calls looks less
> attractive to me than fortifying git_mkstemps_mode() with a good source
> of randomness.

True.

Also, it is not like we are supplying our own implementation of
random source, but are just pluggig various system-supplied random
source into our code, so I do not see the "auditatiblity" problem we
heard earlier too much of an issue.