From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 02 Mar 2022 23:16:51 GMT
Subject: Re: [PATCH 11/15] rev-list tests: don't hide abort() in "test_expect_failure"
Message-ID: <xmqqa6e8gd24.fsf@gitster.g>
In-Reply-To: <patch-11.15-26c838f0560-20220302T171755Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Change a couple of uses of "test_expect_failure" to use a
> "test_expect_success" to positively assert the current behavior, and
> replace the intent of "test_expect_failure" with a "TODO" comment int
> the description.
>
> As noted in [1] the "test_expect_failure" feature is overly eager to

And noted in [2], it is not a good idea to abuse "test_expect_success"
for this purpose, either, though.

[2] https://lore.kernel.org/git/xmqq4k9kj15p.fsf@gitster.g/