From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 08 Sep 2024 21:32:46 GMT
Subject: Re: [PATCH v3 2/6] libgit-sys: introduce Rust wrapper for libgit.a
Message-ID: <xmqqa5ghx24h.fsf@gitster.g>
In-Reply-To: <20240906230419.r4hej7qsmx7yasl7@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> On Fri, Sep 06, 2024 at 06:39:17PM -0400, Eric Sunshine wrote:
>> > diff --git a/contrib/libgit-rs/libgit-sys/build.rs b/contrib/libgit-rs/libgit-sys/build.rs
>> > @@ -0,0 +1,31 @@
>> > +pub fn main() -> std::io::Result<()> {
>> > +    let crate_root = PathBuf::from(env::var_os("CARGO_MANIFEST_DIR").unwrap());
>> > +    let git_root = crate_root.join("../../..");
>> > +    let dst = PathBuf::from(env::var_os("OUT_DIR").unwrap());
>> > +
>> > +    let make_output = std::process::Command::new("make")
>> 
>> Providing a mechanism for people to override this hardcoded spelling
>> of "make" could be another item for your NEEDSWORK list; in
>> particular, I'm thinking about platforms on which GNU "make" is
>> installed as "gmake".
>
> And/or, use the `make_cmd` crate.

Thanks for helping.