From: Junio C Hamano Date: Tue, 11 Mar 2025 23:29:27 GMT Subject: Re: [PATCH v6 00/18] reftable: stop using "git-compat-util.h" Message-ID: In-Reply-To: Junio C Hamano writes: > Patrick Steinhardt writes: > >> Changes in v6: >> - I have rebased the patch series on top of "master" at 03944513488 >> (The eleventh batch, 2025-02-14). On the one hand this gets rid of >> the conflict with the zlib-ng changes, which have meanwhile been >> merged to that branch. And on the other hand it pulls in the new CI >> build for MSVC+Meson, which allows me to have better test coverage >> on Windows to better detect breakage there. >> - Stop moving around Win32 files so that we do the minimum viable >> change in this context. Hopefully, this makes it easier for Dscho to >> integrate into Git for Windows. If it doesn't I don't really have >> any other good ideas for how to do it, so the only alternative would >> be to just ignore Windows altogether. >> - Link to v5: https://lore.kernel.org/r/20250207-pks-reftable-drop-git-compat-util-v5-0-ba2adc79110f@pks.im > > Thanks. I think the "unlink" thing on Windows I have was queued > depended on the previous iteration of this series so let me make > sure that I'd unentangle it while replacing the topic with this > round. > > Will queue. Thanks. So, sorry I lost track. I think I saw you ask Dscho about the Windows specific bits once in a thread on What's cooking report, but I do not recall the outcome. Is this topic (and the unlink fix that depends on this series) now OK, or would we see further updates once 2.49 is tagged? Thanks.