From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 17 May 2025 18:39:42 GMT
Subject: Re: [PATCH v2 2/3] docs: clarify cmd_psuh signature and explain UNUSED macro
Message-ID: <xmqqa57bqdxt.fsf@gitster.g>
In-Reply-To: <xmqq34d3s6ed.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> K Jayatheerth <jayatheerthkulkarni2005@gmail.com> writes:
>
>> The documentation previously omitted the UNUSED macro,
>> which often led to confusion for new contributors
>> when they encountered compiler warnings related to unused parameters.
>
> The above is not quite easy to reason about.  It is more like we
> wrote this document, and then later tightened the default compiler
> warnings for developer builds.  So "omitted" may technically be
> correct, but it was more like "did not use it, because there was no
> need".
>
>     The sample program, as written, would not build for at least two
>     reasons:

"not" -> "no longer" to hint that the change in the environment,
not a bug in the document, is the reason of breakage.

>     - Since this document was first written, the calling convention
>       to subcommand implementation has changed, and now cmd_psuh()
>       needs to accept the third parameter, repository.

"third" -> "fourth"; I cannot count X-<.