From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Nov 2025 20:00:21 GMT
Subject: Re: [PATCH 2/2] builtin/repo: fix table alignment for UTF-8 characters
Message-ID: <xmqqa50oiduy.fsf@gitster.g>
In-Reply-To: <a50bcde6446fbd87b4fb04b28c579a915457813a.1763098804.git.worldhello.net@gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

Not about the contents of the patch, but how was the list of
addresses on CC produced?  Do they all have enough stakes in the
code being updated that they do not mind getting spammed like this?

Also, you had a non-address "Gemini <noreply@developers.google.com>",
which forced me and anybody who will respond to the patch edit Cc
address list (or suffer bounces).  Please don't.

> The output table from "git repo structure" is misaligned when displaying
> UTF-8 characters (e.g., non-ASCII glyphs). E.g.:
>
>     | 仓库结构   | 值  |
>     | -------------- | ---- |
>     | * 引用       |      |
>     |   * 计数     |   67 |
>     |     * 分支   |    6 |
>     |     * 标签   |   30 |
>     |     * 远程   |   19 |
>     |     * 其它   |   12 |
>     |                |      |
>     | * 可达对象 |      |
>     |   * 计数     | 2217 |
>     |     * 提交   |  279 |
>     |     * 树      |  740 |
>     |     * 数据对象 | 1168 |
>     |     * 标签   |   30 |

As there is a concrete reproduction sample from a specific tool, ...

>  builtin/repo.c | 22 ++++++++++++++++++----
>  1 file changed, 18 insertions(+), 4 deletions(-)

... it is a good idea to protect the change with a new test or two
to make sure the expected alignment in the output.

Thanks.