From: Junio C Hamano Date: Wed, 04 Feb 2026 17:53:10 GMT Subject: Re: [PATCH v2] meson: wire up gitk and git-gui Message-ID: In-Reply-To: <20260204-b4-pks-meson-tcl-tk-v2-1-5bc3ccf3a8ce@pks.im> Patrick Steinhardt writes: > Wire up both gitk and git-gui in Meson as subprojects. These two > programs should be the last missing pieces for feature compatibility > with our Makefile for distributors. > > Note that Meson expects subprojects to live in the "subprojects/" > directory. Create symlinks to fulfill this requirement. > > Signed-off-by: Patrick Steinhardt > --- > Hi, > > I have upstreamed support for Meson into both gitk [1] and git-gui [2]. > This small patch series wires up support in Git. > > Changes in v2: > - Use symlinks instead of moving both gitk and git-gui into the > "subprojects/" directory. Just being curious (as I cannot offer an alternative if the answer turns out to be "oops, no"), but is Windows, which has been symlink challenged for quite some time, happy with this? > diff --git a/subprojects/git-gui b/subprojects/git-gui > new file mode 120000 > index 0000000000..c6d917088b > --- /dev/null > +++ b/subprojects/git-gui > @@ -0,0 +1 @@ > +../git-gui > \ No newline at end of file > diff --git a/subprojects/gitk b/subprojects/gitk > new file mode 120000 > index 0000000000..b66ad18ae5 > --- /dev/null > +++ b/subprojects/gitk > @@ -0,0 +1 @@ > +../gitk-git > \ No newline at end of file Completely unrelated, but I think there needs a way to decorate a .gitattributes pattern specify symlinks (and non-symlinks), just like "foo/" makes the pattern match only to a directory and not file "foo", so that whitespace=incomplete-lines does not kick in for them. Alternatively, make symbolic links excempt from whitespace=incomplete-lines rule altogether.