From: Junio C Hamano Date: Thu, 08 Oct 2026 18:05:28 GMT Subject: Re: [PATCH 1/8] t5004: skip SHA-1-only test in SHA-256 repository Message-ID: In-Reply-To: <20261008-pks-ci-housekeeping-v1-1-baf015c589c0@pks.im> Patrick Steinhardt writes: > One of the tests in t5004 extracts a ZIP file that contains some objects > larger than 4GB and then double-checks whether we can read and archive > such an object. That test has a bunch of prerequities: it requires a 64 > bit `long`, unzip with 64-bit support and it only runs when EXPENSIVE is > enabled. Consequently, not a lot of jobs even exercise this. > > One of the jobs that does run it though our Fedora-based job, as it "One of the jobs that does run it though" IS "our Fedora-based job"? > ticks all the necessary boxes. But that job was silently broken: while > the intent was to run on Fedora with breaking changes enabled, they are > in fact disabled due to a typo. > > We're about to fix that typo in the next commit, but this will also > uncover that the above test case is broken when running in SHA-256 > repositories. The extracted objects are SHA-1 objects, so extracting > them into a SHA-256 repository is not going to yield anything good. So > once we fix the Fedora-based job to enable breaking changes, which will > make tests use SHA-256 by default, the test will break. > > Fix this issue by adding the SHA1 prerequisite. > > Signed-off-by: Patrick Steinhardt > --- > t/t5004-archive-corner-cases.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t5004-archive-corner-cases.sh b/t/t5004-archive-corner-cases.sh > index 768b0ff85d..c9c879cc5f 100755 > --- a/t/t5004-archive-corner-cases.sh > +++ b/t/t5004-archive-corner-cases.sh > @@ -185,7 +185,7 @@ test_expect_success EXPENSIVE,UNZIP,UNZIP_ZIP64_SUPPORT \ > "$GIT_UNZIP" -t many-big.zip > ' > > -test_expect_success EXPENSIVE,LONG_IS_64BIT,UNZIP,UNZIP_ZIP64_SUPPORT,ZIPINFO \ > +test_expect_success EXPENSIVE,LONG_IS_64BIT,UNZIP,UNZIP_ZIP64_SUPPORT,ZIPINFO,SHA1 \ > 'zip archive with files bigger than 4GB' ' > # Pack created with: > # dd if=/dev/zero of=file bs=1M count=4100 && git hash-object -w file