From: Junio C Hamano Date: Wed, 04 Nov 2026 19:18:37 GMT Subject: Re: [PATCH 04/10] commit-graph: drop redundant flags in write context Message-ID: In-Reply-To: <20261104-pks-commit-graph-write-refactorings-v1-4-d013d9401a59@pks.im> Patrick Steinhardt writes: > In the preceding commit we have moved the flags that control how we > write a commit graph into its options structure. As a consequence we > have those flags implicitly available in the write context, too, as it > already contains a pointer to the options struct. This makes a couple of > individual flags that we track in the write context redundant as they > are a simple alias of the flags. > > Drop these redundant flags. > ... > struct write_commit_graph_context ctx = { > .r = r, > - .append = opts->flags & COMMIT_GRAPH_WRITE_APPEND ? 1 : 0, > - .report_progress = opts->flags & COMMIT_GRAPH_WRITE_PROGRESS ? 1 : 0, > - .split = opts->flags & COMMIT_GRAPH_WRITE_SPLIT ? 1 : 0, OK, so these are the most important lines in this patch; everything else is there as a fallout of this change, and as a result, the remaining code has become much easier to follow. Nicely done.