From: Junio C Hamano Date: Sun, 22 Apr 2012 05:25:07 GMT Subject: Re: What's cooking in git.git (Apr 2012, #08; Fri, 20) Message-ID: In-Reply-To: <20120421102335.GA29660@goldbirke> SZEDER Gábor writes: > On Fri, Apr 20, 2012 at 05:06:20PM -0700, Junio C Hamano wrote: >> * fc/completion-tests (2012-04-18) 7 commits >> - tests: add tests for the __gitcomp() completion helper function >> - completion: fix completion after 'git --option ' >> - completion: avoid trailing space for --exec-path >> - completion: add missing general options >> - completion: simplify by using $prev >> - completion: simplify __gitcomp_1 >> - tests: add initial bash completion tests > > Perhaps you could move 'tests: add tests for the __gitcomp() > completion helper function' from the top after 'tests: add initial > bash completion tests', to show that Felipe's 'completion: simplify > __gitcomp_1' doesn't break any of the tests. I don't mind. Felipe, what do you think?