From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Sep 2013 16:26:13 GMT
Subject: Re: [PATCH] diff: add a config option to control orderfile
Message-ID: <xmqq8uyv1kka.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20130915080830.GA30465@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> writes:

> Actually, after I've looked at the code,
> diffcore_order is already already called for patch-id.

That was a band-aid for an ill-thought-out orderfile misfeature to
hide the breakage.  You somehow make sure that you pass the same
orderfile to diff generating machinery used internal to patch-id
generation.  The standalone "git patch-id" would be reading the
patch in the order you give it when you are feeding a patch somebody
sent you via the mailing list using an order unknown to you, no?

Before making it _easier_ to use the orderfile to generate diffs, we
would need to prepare the parts that will be broken by wider use of
the feature.