From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 07 Mar 2014 21:49:05 GMT
Subject: Re: [PATCH v7 00/11] Add interpret-trailers builtin
Message-ID: <xmqq8uslu1bi.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140306220029.29150.64594.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

> * many style fixes

This round is readable ;-)  Thanks.

> * clearer and nicer setup tests

Those long lines that use "printf" with many embedded \n were harder
to read and also looked harder to maintain if we ever wanted to
change them.  Splicing a string with \n in the middle of a long
single line is far harder than adding an independent line, I would
think.  For example:

	... &&
	printf "Fixes: \nAcked-by= \nReviewed-by: \nSigned-off-by: \n" >>expected &&
	...

is easier to read and maintain if written like so (with using HT
properly---our MUAs may damage it and turn the indentation into
spaces):

	... &&
	sed -e "s/ Z$/ /" >>expect <<-\EOF &&
        Fixes: Z
        Acked-by= Z
        Reviewed-by: Z
        Signed-off-by: Z
	EOF
	...