From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Jun 2015 18:36:05 GMT
Subject: Re: [PATCH/RFC v2 5/5] send-email: refactor address list process
Message-ID: <xmqq8ubuavze.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpqk2ve9tfm.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr> writes:
>
>> Simplify code by creating a function to transform list of email lists
>> (comma separated, with aliases ...)  into a simple list of valid email
>> addresses.
>
> I would have found the series easier to read if this refactoring came
> earlier (and then PATCH 2/5 would fix the bug as a positive side effect
> of the refactoring).

I agree that doing 5/5 sooner would make 4/5 a lot clearer.  

Introducing the helper of 5/5 before 2/5 happens, and then replacing
two calls to validate-address-list with process-address-list would
hide the nature of the change, i.e. fixing a bug, so it is better to
see it done before the refactoring of 5/5, provided if it is indeed
a bug that these were not expanded.