From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Sep 2015 22:18:59 GMT
Subject: Re: [PATCH 66/67] use strbuf_complete to conditionally append slash
Message-ID: <xmqq8u86m2i4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20150915161619.GN29753@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> diff --git a/imap-send.c b/imap-send.c
> index 01aa227..f5d2b06 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1412,8 +1412,7 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
>  	curl_easy_setopt(curl, CURLOPT_PASSWORD, server.pass);
>  
>  	strbuf_addstr(&path, server.host);
> -	if (!path.len || path.buf[path.len - 1] != '/')
> -		strbuf_addch(&path, '/');
> +	strbuf_complete(&path, '/');
>  	strbuf_addstr(&path, server.folder);

Is this conversion correct?  This seems to me that the caller wants
to create an IMAP folder name immediately under the root hierarchy
and wants to have the leading slash in the result.