From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 10 Dec 2015 23:38:24 GMT
Subject: Re: [PATCH 2/2] push: Use "last one wins" convention for --recurse-submodules
Message-ID: <xmqq8u51ho27.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kbxvrMHnJx9iACus44+rmFf6ZNFPArrpVhNr6ZTDj+XOg@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

>> +               git push --recurse-submodules=on-demand --no-recurse-submodules ../pub.git master &&
>> +               # Check that the submodule commit did not get there
>
> Do we want to check here that the supermodule commit did get there,
> instead of only checking the submodule?

Hmm, your point is that when the push succeeds, (1) the command
should return with 0 status, (2) the branch in the superproject
should update to the right commit, and (3) none of the submodule
should be affected, and the current test does not check the second
one?

I think that makes sense, in somewhat a paranoid way ;-).