From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 08 Sep 2016 21:30:49 GMT
Subject: Re: [PATCH v2 3/3] Use the newly-introduced regexec_buf() function
Message-ID: <xmqq8tv2f59y.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160908195300.votzp3ysxewc2mip@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> commit f96e5673 ("grep: use REG_STARTEND for all matching if available",
>> 22-05-2010) introduced this test and expects ".. NUL characters themselves
>> are not matched in any way". With the native library on cygwin they are
>> matched, with the compat/regex they are not. Indeed, if you use the system
>> 'grep' command (rather than 'git grep'), then it will also not match ... :-D
>> 
>> Slightly off topic, but ...
>
> Hmm. So it sounds like the "regmatch" in grep.c could go away in favor
> of Johannes's regexec_buf(), and cygwin ought to be using NO_REGEX.

Sounds like a plan.