From: Junio C Hamano Date: Wed, 21 Sep 2016 15:40:17 GMT Subject: Re: What's cooking in git.git (Sep 2016, #05; Mon, 19) Message-ID: In-Reply-To: Johannes Schindelin writes: >> * jk/rebase-i-drop-ident-check (2016-07-29) 1 commit >> (merged to 'next' on 2016-08-14 at 6891bcd) >> + rebase-interactive: drop early check for valid ident >> >> Even when "git pull --rebase=preserve" (and the underlying "git >> rebase --preserve") can complete without creating any new commit >> (i.e. fast-forwards), it still insisted on having a usable ident >> information (read: user.email is set correctly), which was less >> than nice. As the underlying commands used inside "git rebase" >> would fail with a more meaningful error message and advice text >> when the bogus ident matters, this extra check was removed. >> >> Will hold to see if people scream. >> cf. <20160729224944.GA23242@sigill.intra.peff.net> > > Let's do this. We have already been doing it (i.e. "hold to see if people scream") for some time. Does it conflict with your effort to reimplement "rebase -i" in C to keep this in 'next'? Do you want it to move to 'master'? I was under the impression that it would not make a difference to have or not have this patch once your reimplementation gets merged (meaning: the removal of the three lines will be done by wholesale removal of git-rebase--interactive.sh done the endgame of your series), so...