From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 25 Oct 2017 01:48:08 GMT
Subject: Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
Message-ID: <xmqq8tg0j8vb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171024195221.gqgtibwjaztgeel6@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I definitely agree with the sentiment that as few things as possible
> should happen between calling getenv() and using its result. I've seen
> real bugs there from unexpected invalidation of the static buffer.

Sure.  I do not think we mind xstrdup()ing the result and freeing
after we are done, though ;-)