From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Jul 2018 20:37:28 GMT
Subject: Re: [GSoC][PATCH v2 6/7] rebase -i: rewrite setup_reflog_action() in C
Message-ID: <xmqq8t6soy2f.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180702105717.26386-7-alban.gruin@gmail.com>

Alban Gruin <alban.gruin@gmail.com> writes:

> +static int run_git_checkout(struct replay_opts *opts, const char *commit,
> +				int verbose, const char *action)
> +{
> +	struct child_process cmd = CHILD_PROCESS_INIT;
> +
> +	cmd.git_cmd = 1;
> +
> +	argv_array_push(&cmd.args, "checkout");
> +	argv_array_push(&cmd.args, commit);
> +	argv_array_pushf(&cmd.env_array, GIT_REFLOG_ACTION "=%s", action);
> +
> +	if (verbose)
> +		return run_command(&cmd);
> +	return run_command_silent_on_success(&cmd);

I thought we made this into

	if verbose
		return run_command
	else
		return run_command_silently

to help readers in the previous round already.

Are we reviewing the correct version?