From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 08 Nov 2019 05:01:05 GMT
Subject: Re: [PATCH v5 3/9] built-in add -i: implement the `status` command
Message-ID: <xmqq8sorner2.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <6aaa0de4f4564b1d8da0691851dac0d22f87e565.1572869730.git.gitgitgadget@gmail.com>

"Daniel Ferreira via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Daniel Ferreira <bnmvco@gmail.com>
>
> This implements the `status` command of `git add -i`. The data
> structures introduced in this commit will be extended later, as needed.
>
> At this point, we re-implement only part of the `list_and_choose()`
> function of the Perl script `git-add--interactive.perl` and call it
> `list()`. It does not yet color anything, or do columns, or allow user
> input.

OK, so that is why we unconditionally do the status thing directly
inside run_add_i() and nothing else.  Makes sense.

> Over the course of the next commits, we will introduce a
> `list_and_choose()` function that uses `list()` to display the list of
> options and let the user choose one or more of the displayed items. This
> will be used to implement the main loop of the built-in `git add -i`, at
> which point the new `status` command can actually be used.

Very well written.