From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 27 Apr 2020 22:16:42 GMT
Subject: Re: [PATCH 1/2] fetch-pack: in protocol v2, in_vain only after ACK
Message-ID: <xmqq8sig7ewl.fsf@gitster.c.googlers.com>
In-Reply-To: <20200427172736.61159-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>> not about this patch: can these return values from process_acks be made
>> into an enum with named enumerators?  That would make what's happening
>> in the call site more obvious.
>
> That sounds reasonable to me.
>
>> > +	cp trace /tmp/x &&
>> 
>> Leftover debugging line?
>
> Ah, yes. If Junio can't or won't do it locally then I'll send out
> another set with this changed.

Well, if I am expecting the "named enumerators" patch anyway, I'd
wait the fix to be done at the source ;-)