From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 04 May 2020 21:09:03 GMT
Subject: Re: [PATCH] commit-graph: avoid memory leaks
Message-ID: <xmqq8si7flw0.fsf@gitster.c.googlers.com>
In-Reply-To: <20200504191324.201663-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> A fuzzer running on the entry point provided by fuzz-commit-graph.c
> revealed a memory leak when parse_commit_graph() creates a struct
> bloom_filter_settings and then returns early due to error. Fix that
> error by always freeing that struct first (if it exists) before
> returning early due to error.
>
> While making that change, I also noticed another possible memory leak -
> when the BLOOMDATA chunk is provided but not BLOOMINDEXES. Also fix that
> error.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
> Here's a memory leak fix revealed by a fuzzer running at $DAYJOB, and
> another one that I noticed while making that fix.
> ---

Thanks.  The patch looks good.

Will queue.