From: Junio C Hamano Date: Tue, 21 Jul 2020 23:25:03 GMT Subject: Re: [PATCH] sha1-file: make pretend_object_file() not prefetch Message-ID: In-Reply-To: <20200721225020.1352772-1-jonathantanmy@google.com> Jonathan Tan writes: > To make progress towards solving this, I'm thinking of making a new > function has_object() that takes a repository, an object ID, and flags, > and only supports one flag: HAS_OBJECT_RECHECK_PACKED (which has the > opposite meaning of OBJECT_INFO_QUICK). Checks that should not fetch > should use has_object(), and checks that should fetch (if they exist - I > think that most would want additional information about the object, so > they would use oid_object_info() or similar already) should use > oid_object_info() or a similar function. That way we can see how many > uses of has_object_file() we have checked, and at the same time make > behavior we usually want into the default behavior. Any opinions? Yes, a new function (or a pair of functions) makes it easy to see how much progress we made and also gives us easier greppability.