From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 13 Feb 2021 01:06:50 GMT
Subject: Re: [PATCH v2 2/2] diffcore-rename: filter rename_src list when possible
Message-ID: <xmqq8s7svkr9.fsf@gitster.c.googlers.com>
In-Reply-To: <7ae9460d3dba84122c2674b46e4339b9d42bdedd.1612382628.git.gitgitgadget@gmail.com>

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> @@ -578,8 +624,7 @@ void diffcore_rename(struct diff_options *options)
>  			struct diff_filespec *one = rename_src[j].p->one;
>  			struct diff_score this_src;
>  
> -			if (one->rename_used && !want_copies)
> -				continue;
> +			assert(!one->rename_used || want_copies || break_idx);

Doesn't assert becomes a no-op in production builds?  Shouldn't this
be a BUG() instead?