From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Mar 2021 01:11:28 GMT
Subject: Re: [PATCH] t9801: replace test -f with test_path_is_file
Message-ID: <xmqq8s73g1tr.fsf@gitster.c.googlers.com>
In-Reply-To: <20210302185056.65929-1-shubhunic@gmail.com>

Shubham Verma <shubhunic@gmail.com> writes:

> -		test -f file1 &&
> -		test -f file2 &&
> +		test_path_is_file file1 &&
> +		test_path_is_file file2 &&
>  		test ! -f file3 &&

You chose not to touch the last one, which is the right thing to do.
Replacing "test -f P" with "test_path_is_file P" can be done
mechanically, but it takes understanding of what the test is doing
to come up the correct replacement for "test ! -f P".  It may be
expecting P to be a directory, or it may be expecting P to be
missing, for example.

Will queue.  Thanks.