From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 11 May 2021 21:31:05 GMT
Subject: Re: [PATCH] tr2: log parent process name
Message-ID: <xmqq8s4lkleu.fsf@gitster.g>
In-Reply-To: <87im3qu4gy.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Thu, May 06 2021, Emily Shaffer wrote:
>
>> It can be useful to tell who invoked Git - was it invoked manually by a
>> user via CLI or script? By an IDE? Knowing where the Git invocation came
>> from can help with debugging to isolate where the problem came from.
>
> Aside from the portability concerns others have raised, I don't really
> see why you'd need this.
>
> We already have the nest-level as part of the SID, so isn't it
> sufficient (and portable) at the top-level to log what isatty says + set
> the initial SID "root" in the IDE (which presumably knows about git).
>
> Wouldn't this log passwords in cases of e.g.:
>
>     some-script --git-password secret # invokes "git"

Both valid and excellent points, I would think.