From: Junio C Hamano Date: Wed, 02 Mar 2022 19:26:12 GMT Subject: Re: [PATCH v4 8/9] Makefile: use $(wspfx) for $(QUIET...) in shared.mak Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason writes: > Change the mostly move-only change in the preceding commit to use the > $(wspfx) variable for defining the QUIET padding. This refactoring > will make it easier to emit that exact amount of padding in functions > that we might add to shared.mak in the future. > > Such a function is not part of this patch series, but a > "TRACK_template" that I'd like to add as a follow-up to it makes use > of this. Let's make this change now while modifying these QUIET rules > is fresh in our minds. I do not see why this change is still part of this series, then. > ## Used in "Makefile" > - QUIET_CC = @echo ' ' CC $@; > - QUIET_AR = @echo ' ' AR $@; > ... > + QUIET_CC = @echo $(wspfx_SQ) CC $@; > + QUIET_AR = @echo $(wspfx_SQ) AR $@; > ... Look how much uglier these lines got. Without the benefit TRACK_template brings us, whatever that is, this change looks more of an unnecessary churn. Let's leave it to the later series that introduces the user that justifies this change.