From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 19 Oct 2023 20:16:55 GMT
Subject: Re: Is there any interest in localizing term delimiters in git messages?
Message-ID: <xmqq8r7yweo8.fsf@gitster.g>
In-Reply-To: <20231019194747.GC25301@tb-raspi4>

Torsten Bögershausen <tboegi@web.de> writes:

> The switch case covers all 8 values of "enum crlf_action",
> and removing these 2 lines
>  -	warning("Illegal crlf_action %d\n", (int)crlf_action);
>  -	return core_eol;
> does still compile without a compiler warning.
> So yes, a BUG is more appropriate here.

Yeah, and if our expectation is whenever we add a new value to enum
convert_crlf_action, we will handle in and return from the switch
statement, so I agree with you that BUG() is more appropriate.

Thanks for a quick response.  Note that this was something we
discovered while talking about i18n and no immediate action is
required---it is not like we saw a report that tells us that end
users are actively getting confused by this message.

Thanks.