From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 22 Aug 2024 16:06:45 GMT
Subject: Re: [PATCH 19/20] transport: fix leaking arguments when fetching from bundle
Message-ID: <xmqq8qwotucq.fsf@gitster.g>
In-Reply-To: <Zsb0qU-G4kdlxrWa@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

> Yes we do, because there is an early return in case `verify_bundle()`
> fails. I didn't notice that we have it in `unbundle()` though.

Ah, I missed that one.

> I'd argue it's bad practice to have `unbundle()` clear the caller
> provided args for us and somewhat surprising.

I was surprised so it makes it at least two of us.  In some call
patterns, having the callee _consume_ what the caller fed it may
be natural, but not in this code path.

Thanks.