From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 Nov 2024 00:44:10 GMT
Subject: Re: [PATCH v2] fast-import: avoid making replace refs point to themselves
Message-ID: <xmqq8qtghx2d.fsf@gitster.g>
In-Reply-To: <pull.1824.v2.git.1731968389590.gitgitgadget@gmail.com>

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +		grep "Dropping.*since it would point to itself" msgs &&
> +		git show-ref >refs &&
> +		! grep refs/replace refs

"test_grep !" may make a failure case easier to diagnose.

Other than that, looking good.

Thanks, will queue.