From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 Dec 2024 00:14:37 GMT
Subject: Re: [PATCH v3 6/7] git-submodule.sh: improve variables readability
Message-ID: <xmqq8qsnjcsy.fsf@gitster.g>
In-Reply-To: <20241210184442.10723-7-royeldar0@gmail.com>

Roy Eldar <royeldar0@gmail.com> writes:

> +		-b* | --branch*)
> +			branch="$1"

Once another option like "--branches-only" will be caught by this
case arm.  Do not omit "=" in the pattern.

> @@ -142,14 +142,14 @@ cmd_add()
>  	fi
>  
>  	git ${wt_prefix:+-C "$wt_prefix"} submodule--helper add \
> -		${quiet:+--quiet} \
> -		${force:+--force} \
> -		${progress:+"--progress"} \
> -		${branch:+--branch "$branch"} \
> -		${reference_path:+--reference "$reference_path"} \
> +		$quiet \
> +		$force \
> +		$progress \
> +		${branch:+"$branch"} \
> +		${reference:+"$reference"} \
>  		${ref_format:+"$ref_format"} \
> -		${dissociate:+--dissociate} \
> -		${custom_name:+--name "$custom_name"} \
> +		$dissociate \
> +		${custom_name:+"$custom_name"} \
>  		${depth:+"$depth"} \
>  		-- \
>  		"$@"

Looking good.