From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 22 Jan 2026 22:09:42 GMT
Subject: Re: [RFC PATCH 0/2] Adding string_list_sort_u to replace combined calls of string_list_sort and string_list_remove_duplicates calls.
Message-ID: <xmqq8qdpl2op.fsf@gitster.g>
In-Reply-To: <20260122171523.94234-1-amishhhaaaa@gmail.com>

Amisha Chhajed <amishhhaaaa@gmail.com> writes:

> I was unable to write unit tests for this new method in this RFC PATCH
> since I was quite unsure why no unit tests were present for string_list_sort
> and string_list_insert.

t/unit-tests/u-string-list.c has tests for remove_duplicates,
though.  If one discovers test coverage is lacking, it is perfectly
fine to enhance the coverage, especially the low-level unit tests
are ralatively cheap to run.

Thanks.