From: Junio C Hamano Date: Fri, 03 Jul 2026 02:52:30 GMT Subject: Re: [PATCH v2 05/12] t/unit-tests: introduce test helper to write reftable blocks Message-ID: In-Reply-To: Christian Couder writes: > On Mon, Jun 29, 2026 at 11:02 AM Patrick Steinhardt wrote: >> ... >> +static int cl_reftable_write_block(struct reftable_buf *buf, >> + uint8_t block_type, >> + struct reftable_record *recs, >> + size_t nrecs) > > Yeah, I suggested: > > int cl_reftable_write_block(struct reftable_buf *buf, uint8_t block_type, > size_t block_size, uint32_t header_off, > struct reftable_record *recs, size_t nrecs) > > which accepts `size_t block_size` and `uint32_t header_off` as > arguments, so that more existing tests could be refactored using > cl_reftable_write_block(). > > Your choice to not have these extra arguments is reasonable though, as > they are not needed for the code that your series adds, and they make > the implementation of cl_reftable_write_block() a bit more complex. > > Also they can still be added in the future if we really want to clean > up more existing tests. > > This version of your series looks good to me now. Thanks, both.