From: Junio C Hamano Date: Tue, 14 Jul 2026 20:45:02 GMT Subject: Re: [PATCH 0/5] tempfile: stop using the_repository Message-ID: In-Reply-To: <20260714175956.54601-1-l.s.r@web.de> René Scharfe writes: > create_tempfile_mode() and create_tempfile() use the_repository > internally to call adjust_shared_perm(). Expose that dependency and > push it out to their callers. > > Patch 5 is a bonus; it converts lockfile users that already work with > other repositories. > > tempfile: add repo_create_tempfile{,_mode}() > refs/packed: use repo_create_tempfile() > lockfile: add repo_hold_lock_file_for_update{,_timeout}{,_mode}() > tempfile: stop using the_repository > use repo_hold_lock_file_for_update{,_mode,_timeout}() with custom repos Will queue. If I have a chance I may revisit the topic a bit deeper, but nothing stood out as glaringly wrong to my cursory reading so far. Thanks. > > apply.c | 10 ++++++---- > builtin/difftool.c | 2 +- > builtin/gc.c | 2 +- > builtin/history.c | 2 +- > builtin/sparse-checkout.c | 3 ++- > bundle.c | 4 ++-- > commit-graph.c | 9 +++++---- > config.c | 4 ++-- > lockfile.c | 30 ++++++++++++++++++++++-------- > lockfile.h | 31 +++++++++++++++++++++++++++++++ > loose.c | 6 ++++-- > midx-write.c | 7 ++++--- > odb/source-files.c | 3 ++- > refs/files-backend.c | 10 ++++++---- > refs/packed-backend.c | 9 ++++----- > refs/packed-backend.h | 2 +- > repack-midx.c | 3 ++- > repository.c | 2 +- > rerere.c | 6 +++--- > tempfile.c | 7 +++---- > tempfile.h | 10 +++++++--- > 21 files changed, 110 insertions(+), 52 deletions(-)