From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 30 Jul 2026 16:02:50 GMT
Subject: Re: [PATCH v2] merge-base: add tests for --is-ancestor
Message-ID: <xmqq8q6slb2t.fsf@gitster.g>
In-Reply-To: <pull.2186.v2.git.1785392350660.gitgitgadget@gmail.com>

"Nikolaus Schuetz via GitGitGadget" <gitgitgadget@gmail.com> writes:

>     Changes since v1, per review:
>     
>      * Reuse the E---D---C---B---A history and the G/H merges from the "set
>        up G and H" test instead of creating a separate repository.

Looks good.

>      * Add a test that --is-ancestor requires exactly two commits: too few
>        is a usage error (exit 129), while more than two is rejected with
>        "--is-ancestor takes exactly two commits" (exit 128).

OK.

Will queue.  Thanks.