From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Sep 2013 20:10:44 GMT
Subject: Re: [PATCH v4] peel_onion(): add support for <rev>^{tag}
Message-ID: <xmqq7gexr7i3.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1378237816-28671-1-git-send-email-rhansen@bbn.com>

Richard Hansen <rhansen@bbn.com> writes:

> diff --git a/t/t1511-rev-parse-caret.sh b/t/t1511-rev-parse-caret.sh
> index eaefc77..15973f2 100755
> --- a/t/t1511-rev-parse-caret.sh
> +++ b/t/t1511-rev-parse-caret.sh
> @@ -54,6 +54,13 @@ test_expect_success 'ref^{tree}' '
>  	test_must_fail git rev-parse blob-tag^{tree}
>  '
>  
> +test_expect_success 'ref^{tag}' '
> +	test_must_fail git rev-parse HEAD^{tag} &&
> +	git rev-parse commit-tag >expected &&
> +	git rev-parse commit-tag^{tag} >actual &&
> +	test_cmp expected actual
> +'
> +

Looks good to me.  Testing both failure case and success case.

Thanks; will queue.