From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 20 Mar 2014 17:41:53 GMT
Subject: Re: [PATCH 3/8] ls_colors.c: enable coloring on u+x files
Message-ID: <xmqq7g7ozs0u.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CACsJy8DP3buUjT95LwG+Kd70KL67xqEubrHfu9Mqx1RNa-ER2Q@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> On Thu, Mar 20, 2014 at 6:46 PM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>>
>>> git-compat-util.h does not seem to carry S_IXUGO. Anyway as far as Git
>>> is concerned, we only care one executable bit. Hard code it.
>>
>> Why not use S_IXUSR instead of a hardcoded value? (already used in
>> path.c, so shouldn't be a problem wrt portability)
>
> Hmm..maybe cache.h does something to that macro. Will drop this patch
> and include cache.h.

Why even include cache.h for S_IXUSR?

In the context of the patch I see S_ISGID mentioned and other S_*
st_mode things are already in use in this function before this step,
and presumably you are using them without problems, no?