From: Junio C Hamano Date: Wed, 02 Apr 2014 17:19:04 GMT Subject: Re: [PATCH 18/22] lockfile: also keep track of the filename of the file being locked Message-ID: In-Reply-To: <1396367910-7299-19-git-send-email-mhagger@alum.mit.edu> Michael Haggerty writes: > This reduces the amount of string editing gyrations and makes it > unnecessary for callers to know how to derive the filename from the > lock_filename. Hmph. Is it worth duplicating the whole thing? If you are planning to break the invariant lock_filename === filename + LOCK_SUFFIX in future changes in the series, it is understandable, though.