From: Junio C Hamano Date: Tue, 20 May 2014 18:46:51 GMT Subject: Re: [PATCH v5] format-patch --signature-file Message-ID: In-Reply-To: <20140520182443.GA30533@sigill.intra.peff.net> Jeff King writes: > If it were just "--signature", I'd agree. After all, nobody is even > complaining. But this is also in preparation for --signature-file. > Should the user create a file without a trailing newline? Ahh, I missed that part. I am fine with processing it with stripspace(). By the way, at some point we may want to move that helper function to strbuf.c, but that is a separate issue.